<div dir="ltr"><div><div>Hi Aaron,<br><br></div><div>So I've separated out the kernel settings part as ndt_Only_Kernel_Setup_0.2.diff, attached. This includes some Web10G specific code which is relevant the kernel setup namely start_tcpe( ... ) and revert_tcpe( ... ) in kernel_config.c. These functions check the Web10G module tcp_estats_nl is loaded into the kernel. I've commented out the function calls in web100srv.c so this will still compile. So the Web10G still with bugs fixes but not kernel setup is also attached as ndt_Only_Web10G+Bugs_0.2.diff.<br>
<br></div><div>I've noticed a bug in my code and made a small modification to correct this. Which allows the Web10G server to run without the tcp_estats module loaded, since this is always going to be the case if Web10G is compiled into the kernel.<br>
</div><div><br>As for separating bug fixes and Web10G code. I wanted to keep bug fixes and Web10G separate, however I couldn't accurately test the Web10G code due to some of these bugs. And keeping separate versions for bugs and bugs+Web10G was to much effort. So the bugs I've reported are<br>
</div><div><a href="http://code.google.com/p/ndt/issues/detail?id=69">http://code.google.com/p/ndt/issues/detail?id=69</a><br><a href="http://code.google.com/p/ndt/issues/detail?id=70">http://code.google.com/p/ndt/issues/detail?id=70</a><br>
<a href="http://code.google.com/p/ndt/issues/detail?id=71">http://code.google.com/p/ndt/issues/detail?id=71</a><br><a href="http://code.google.com/p/ndt/issues/detail?id=73">http://code.google.com/p/ndt/issues/detail?id=73</a><br>
<br></div><div>I propose the best way to go about this is work through the bugs first since these also apply to current web100srv code and ideally get these committed to the svn. After this I can go through and update the Web10G patch accordingly. Let me know if this isn't going to work.<br>
</div><div><br>There are one or two bugs in the java applet which I haven't logged as issues yet, I'll do that today. I'll let you know when this is done.<br></div><div><br></div>Cheers,<br></div>Richard<br><div class="gmail_extra">
<br></div><div class="gmail_extra">PS: I'm still putting everything in the google drive folder <a href="https://docs.google.com/folder/d/0B-PiO7DvhNkJUDNwcTZjVGtJNmc/edit">here</a> so it should have a copy of all email attachments.<br>
<br></div><div class="gmail_extra"><div class="gmail_quote">On Wed, Jan 23, 2013 at 5:14 AM, Aaron Brown <span dir="ltr"><<a href="mailto:aaron@internet2.edu" target="_blank">aaron@internet2.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word">Hey Richard,<div><br></div><div>This is great work. Thanks for doing it! One question I had, would it be possible to split out the three different things covered by the patch into three separate patches (i.e. kernel mode setting, bugfix for the issue you reported, and the web10g changes)? It'd make it a bit easier to review each.</div>
<div><br></div><div>Cheers,</div><div>Aaron</div><div><br></div><div><div><div><div class="h5"><div>On Jan 17, 2013, at 1:16 AM, Richard Sanger <<a href="mailto:rsangerarj@gmail.com" target="_blank">rsangerarj@gmail.com</a>> wrote:</div>
<br></div></div><blockquote type="cite"><div><div class="h5"><div dir="ltr"><div><div><div><div>Hi,<br><br></div>As part of an internship at WAND, I've been working on a web10g version of ndt.<br><br></div>The patch is attached.<br>
I've also got some Web10g patched linux kernels for Debian(squeeze or wheezy should work) here.<br>
<a href="https://docs.google.com/folder/d/0B-PiO7DvhNkJUDNwcTZjVGtJNmc/edit" target="_blank">https://docs.google.com/folder/d/0B-PiO7DvhNkJUDNwcTZjVGtJNmc/edit</a><br><br></div><div>NOTE: The kernel needs a slight modification to the Web10g kernel patch. Which is included in the Google drive folder above.<br>
</div><div><br>I've incorporated Web10G into the code in such a way that both the
web100srv and web10g can be built. Besides some bug fixes the web100srv
is unchanged. The configuration process should detect web100 and web10g libraries and build accordingly. Web10G variable logging is not implemented - this shouldn't have any effects on the results.<br><br>For the most part the client hasn't been changed, so an old client can
connect without issues. The only things that could go wrong with an old client are TCP Timestamps/ECN may be incorrectly detected as on.<br><br></div><div>This patch also includes a few fixes for both clients and servers, including those I logged as issues #69 #70 #71 #73.<br>
<br></div><div>Along with web10g this adds code in ndt/src/kernel_* files which will check some of the kernel configuration for a Web10G server and print warnings about incorrect configuration.(If the server is run with -k option these will be corrected).<br>
</div><div><br></div><div>Look at ndt/WEB10G README for more information.<br></div><div><br></div><div>I would be great to get this incorporated into the ndt trunk (or branch). Although the Web10G code still needs more testing the web100 parts of the code are unchanged.<br>
</div><div><br></div><div>Send me an email if you have any issues all feedback is welcome.<br><br></div>Cheers,<br></div>Richard<br></div>
</div></div><span><ndt_Web10G_0.1.diff></span></blockquote></div><br></div></div></blockquote></div><br></div></div>