[Web10g-user] [discussion] Web100/10g lib web100 log file bug

[John S. Estabrook]

Will, thank you for the report and apologies for the delay in 
responding. I have not checked the case you are reporting, but I have no 
doubt it is true; it makes sense, and we had run into a similar bug 
elsewhere.

This is also timely, as we are readying to add logging functionality to 
the Web10G code---it will of necessity have a somewhat different form, 
but I can imagine having repeated this mistake if not for your email, 
so, again, thanks.

On 08/29/12 14:16, Will Hawkins wrote:
> Hello everyone!
>
> First of all, thank you for all your work on these web measurement
> platforms. The data derived from this software is really amazing. As a
> new member of the Mlab team, I've recently started working with the
> userspace libraries for parsing snap files.
>
> The tools seem to work great overall but I've noticed a few bugs. In
> particular, I've noticed a bug in the formatting, encoding and decoding
> of the log files.
>
> After the End-Of-Header marker, the date and time are encoded in the
> file. For encoding, the time is written out of a time_t data structure
> directly into the file. For decoding, the time is read out of the file
> and directly into a time_t data structure.
>
> The way this is coded in web100.c (line 1418 for encoding and line 1541
> for decoding) works perfectly if sizeof(time_t) on the encoding platform
> == sizeof(time_t) on the decoding platform. When the data is encoded on
> a 32-bit machine and decoded on a 64-bit machine, things go wrong.
>
> Fixing the size of this field to either 4- or 8-bytes seems like an easy
> fix. However, there are probably better ways to do it. If there is a
> consensus on the best fix for this, I'd be happy to code it up and
> submit a patch.
>
> Thanks again for the work that you're doing on this project. I look
> forward to interacting with everyone!
>
> Will
> _______________________________________________
> Web100-discussion mailing list
> Web100-discussion at web100.org
> https://lists.psc.edu/mailman/listinfo/web100-discussion
>
> To UNSUBSCRIBE visit https://lists.psc.edu/mailman/unsubscribe/web100-discussion
>

-- 
John Estabrook
NCSA